[
https://issues.apache.org/jira/browse/BEAM-10671?focusedWorklogId=553979&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-553979
]
ASF GitHub Bot logged work on BEAM-10671:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Feb/21 00:01
Start Date: 18/Feb/21 00:01
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #13908:
URL: https://github.com/apache/beam/pull/13908#issuecomment-780920319
# [Codecov](https://codecov.io/gh/apache/beam/pull/13908?src=pr&el=h1) Report
> Merging
[#13908](https://codecov.io/gh/apache/beam/pull/13908?src=pr&el=desc) (4ac92e7)
into
[master](https://codecov.io/gh/apache/beam/commit/ebc3bc31e1f4185241e4a2cf2212772fd7c1fb66?el=desc)
(ebc3bc3) will **increase** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13908?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13908 +/- ##
==========================================
+ Coverage 82.83% 82.91% +0.07%
==========================================
Files 466 469 +3
Lines 57596 58233 +637
==========================================
+ Hits 47711 48283 +572
- Misses 9885 9950 +65
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/13908?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/13908/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5)
| `94.60% <ø> (ø)` | |
|
[...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/13908/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=)
| `40.00% <0.00%> (-3.28%)` | :arrow_down: |
|
[sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/13908/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=)
| `86.45% <0.00%> (-1.05%)` | :arrow_down: |
|
[sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/13908/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==)
| `91.07% <0.00%> (-0.90%)` | :arrow_down: |
|
[...on/apache\_beam/runners/dataflow/dataflow\_runner.py](https://codecov.io/gh/apache/beam/pull/13908/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXIucHk=)
| `82.19% <0.00%> (-0.83%)` | :arrow_down: |
|
[...ache\_beam/runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/13908/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==)
| `90.36% <0.00%> (-0.70%)` | :arrow_down: |
|
[...ache\_beam/runners/portability/local\_job\_service.py](https://codecov.io/gh/apache/beam/pull/13908/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZS5weQ==)
| `80.53% <0.00%> (-0.64%)` | :arrow_down: |
|
[...apache\_beam/runners/dataflow/internal/apiclient.py](https://codecov.io/gh/apache/beam/pull/13908/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9hcGljbGllbnQucHk=)
| `73.13% <0.00%> (-0.35%)` | :arrow_down: |
|
[...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/13908/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==)
| `89.69% <0.00%> (-0.16%)` | :arrow_down: |
|
[sdks/python/apache\_beam/dataframe/expressions.py](https://codecov.io/gh/apache/beam/pull/13908/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2V4cHJlc3Npb25zLnB5)
| `91.02% <0.00%> (-0.14%)` | :arrow_down: |
| ... and [29
more](https://codecov.io/gh/apache/beam/pull/13908/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/13908?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/13908?src=pr&el=footer). Last
update
[ebc3bc3...4ac92e7](https://codecov.io/gh/apache/beam/pull/13908?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 553979)
Time Spent: 12h 50m (was: 12h 40m)
> Add environment configuration fields as first-class pipeline options
> --------------------------------------------------------------------
>
> Key: BEAM-10671
> URL: https://issues.apache.org/jira/browse/BEAM-10671
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-harness
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: P2
> Time Spent: 12h 50m
> Remaining Estimate: 0h
>
> The pipeline option --environment_config has completely different usages
> depending on the value of --environment_type. This is confusing for the user
> and hard to check. Additionally, --environment_config is a JSON blob for
> --environment_type=PROCESS. This JSON blob is a pain to escape and pass
> around compared to a collection of flat strings.
> We should replace --environment_config with first-class / top-level pipeline
> options for each environment type:
> DOCKER
> --environment_container_image
> PROCESS
> --environment_os
> --environment_architecture
> --environment_variables
> EXTERNAL
> --environment_service_address
> LOOPBACK
> (none)
> This way we can validate that the user is configuring these options correctly
> (ie give a warning or error if they use options that do not apply to their
> chosen --environment_type).
> We can deprecate the --environment_config option, logging a warning until
> removing this option altogether in a future Beam release.
> [https://beam.apache.org/documentation/runtime/sdk-harness-config/]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
