[
https://issues.apache.org/jira/browse/BEAM-11833?focusedWorklogId=554414&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-554414
]
ASF GitHub Bot logged work on BEAM-11833:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Feb/21 19:19
Start Date: 18/Feb/21 19:19
Worklog Time Spent: 10m
Work Description: boyuanzz commented on pull request #14013:
URL: https://github.com/apache/beam/pull/14013#issuecomment-781576773
Hi Jan,
From your changes it seems like you want to have
`EmptyUnboundedSource.EmptyUnboundedReader` reports last watermark instead of
`BoundedWindow.TIMESTAMP_MAX_VALUE`. But it's intended to have
`EmptyUnboundedSource.EmptyUnboundedReader` to report
`BoundedWindow.TIMESTAMP_MAX_VALUE` as watermark to mark current restriction
has finished processing and should not hold watermark back.
I checked discussion thread:
https://lists.apache.org/thread.html/r3873ed7e3927c6fc81f6793af779e28cea9bc8f674ec89a7709bde31%40%3Cuser.beam.apache.org%3E
and in your last comment you are saying that `The problem is that under heavy
load (i.e. when the UnboundedReader reads data without ever returning false in
response to advance()) the watermark is not progressed correctly.`. Would you
like to elaborate more on the relationship between this comment and this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 554414)
Time Spent: 0.5h (was: 20m)
> UnboundedSourceAsSDFRestrictionTracker reports incorrect watermark after
> failed claim
> -------------------------------------------------------------------------------------
>
> Key: BEAM-11833
> URL: https://issues.apache.org/jira/browse/BEAM-11833
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.28.0
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: P1
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> After being split by call to {{trySplit}}, the watermark reported by
> {{UnboundedSourceAsSDFRestrictionTracker.currentRestriction().getWatermark()}}
> is BoundedWindow.TIMESTAMP_MAX_VALUE, which is incorrect.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
