[
https://issues.apache.org/jira/browse/BEAM-11833?focusedWorklogId=554534&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-554534
]
ASF GitHub Bot logged work on BEAM-11833:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Feb/21 00:25
Start Date: 19/Feb/21 00:25
Worklog Time Spent: 10m
Work Description: boyuanzz edited a comment on pull request #14013:
URL: https://github.com/apache/beam/pull/14013#issuecomment-781726100
Hi Jan,
You are right that that UnboundedSourceAsSDFWrapperDoFn doesn't update
watermark correctly while tryClaim() is called. I think we should fix
UnboundedSourceAsSDFWrapperDoFn instead of
EmptyUnboundedSource.EmptyUnboundedReader. Here is my one line fix which does
the same thing as yours: https://github.com/apache/beam/pull/14020. I really
like your test so would you like to consider patching my fix into your PR if my
fix makes sense to you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 554534)
Time Spent: 50m (was: 40m)
> UnboundedSourceAsSDFRestrictionTracker reports incorrect watermark after
> failed claim
> -------------------------------------------------------------------------------------
>
> Key: BEAM-11833
> URL: https://issues.apache.org/jira/browse/BEAM-11833
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.28.0
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: P1
> Time Spent: 50m
> Remaining Estimate: 0h
>
> After being split by call to {{trySplit}}, the watermark reported by
> {{UnboundedSourceAsSDFRestrictionTracker.currentRestriction().getWatermark()}}
> is BoundedWindow.TIMESTAMP_MAX_VALUE, which is incorrect.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
