[
https://issues.apache.org/jira/browse/BEAM-6627?focusedWorklogId=196165&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-196165
]
ASF GitHub Bot logged work on BEAM-6627:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Feb/19 11:22
Start Date: 08/Feb/19 11:22
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #7772: [BEAM-6627]
Added Metrics API processing time reporting to TextIOIT
URL: https://github.com/apache/beam/pull/7772#discussion_r255017254
##########
File path:
sdks/java/testing/load-tests/src/main/java/org/apache/beam/sdk/loadtests/metrics/TimeMonitor.java
##########
@@ -30,7 +29,7 @@
* distribution of element processing timestamps, which can be collected and
queried using {@link
* MetricsReader}.
*/
-public class TimeMonitor<K, V> extends DoFn<KV<K, V>, KV<K, V>> {
Review comment:
Thanks for making it more generic. Now that the `TimeMonitor` is used not
only in load tests, could you move it to `beam-sdks-java-test-utils` module?
This way there will be no need to import load tests in every IOIT (they still
have to use utils).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 196165)
Time Spent: 40m (was: 0.5h)
> Use Metrics API in IO performance tests
> ---------------------------------------
>
> Key: BEAM-6627
> URL: https://issues.apache.org/jira/browse/BEAM-6627
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Michal Walenia
> Assignee: Michal Walenia
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
