[
https://issues.apache.org/jira/browse/BEAM-6627?focusedWorklogId=196171&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-196171
]
ASF GitHub Bot logged work on BEAM-6627:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Feb/19 11:22
Start Date: 08/Feb/19 11:22
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #7772: [BEAM-6627]
Added Metrics API processing time reporting to TextIOIT
URL: https://github.com/apache/beam/pull/7772#discussion_r255020654
##########
File path:
sdks/java/io/file-based-io-tests/src/test/java/org/apache/beam/sdk/io/text/TextIOIT.java
##########
@@ -108,13 +110,20 @@ public void writeThenReadAll() {
.apply(
"Produce text lines",
ParDo.of(new
FileBasedIOITHelper.DeterministicallyConstructTestTextLineFn()))
+ .apply(
+ "Log write start time",
Review comment:
Could you change "Log" to "Collect"? It may be just me but when I hear/see
"Log" I expect that this will appear in some console. Here we are just
collecting them and then reading from PipelineResult.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 196171)
Time Spent: 1h 20m (was: 1h 10m)
> Use Metrics API in IO performance tests
> ---------------------------------------
>
> Key: BEAM-6627
> URL: https://issues.apache.org/jira/browse/BEAM-6627
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Michal Walenia
> Assignee: Michal Walenia
> Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
