[
https://issues.apache.org/jira/browse/BEAM-6628?focusedWorklogId=196512&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-196512
]
ASF GitHub Bot logged work on BEAM-6628:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Feb/19 02:55
Start Date: 09/Feb/19 02:55
Worklog Time Spent: 10m
Work Description: kmjung commented on pull request #7783: [BEAM-6628]
Update GCP dependency versions.
URL: https://github.com/apache/beam/pull/7783#discussion_r255284812
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/GcpApiSurfaceTest.java
##########
@@ -96,7 +107,8 @@ public void testGcpApiSurface() throws Exception {
classesInPackage("org.apache.beam"),
classesInPackage("org.apache.commons.logging"),
classesInPackage("org.codehaus.jackson"),
- classesInPackage("org.joda.time"));
+ classesInPackage("org.joda.time"),
+ classesInPackage("org.threeten.bp"));
Review comment:
This is a dependency of gax-grpc for some Duration classes. It's pulled in
by 1.1.0 Spanner release, which now uses a GAX OperationFuture instead of a
Spanner Operation in CreateDatabase:
https://github.com/googleapis/google-cloud-java/blob/master/google-cloud-clients/google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClient.java#L63
We could move it off of the API surface by using a wrapper class instead of
exposing the Spanner client objects directly in SpannerAccessor:
https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 196512)
Time Spent: 1h 10m (was: 1h)
> Update GCP dependencies to a recent version
> -------------------------------------------
>
> Key: BEAM-6628
> URL: https://issues.apache.org/jira/browse/BEAM-6628
> Project: Beam
> Issue Type: Task
> Components: io-java-gcp
> Reporter: Kenneth Jung
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Update GCP client libraries to a recent version. These libraries must be
> updated together in order to keep shared dependencies in sync.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
