[
https://issues.apache.org/jira/browse/BEAM-6628?focusedWorklogId=197047&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197047
]
ASF GitHub Bot logged work on BEAM-6628:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Feb/19 17:05
Start Date: 11/Feb/19 17:05
Worklog Time Spent: 10m
Work Description: swegner commented on pull request #7783: [BEAM-6628]
Update GCP dependency versions.
URL: https://github.com/apache/beam/pull/7783#discussion_r255602659
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/GcpApiSurfaceTest.java
##########
@@ -96,7 +107,8 @@ public void testGcpApiSurface() throws Exception {
classesInPackage("org.apache.beam"),
classesInPackage("org.apache.commons.logging"),
classesInPackage("org.codehaus.jackson"),
- classesInPackage("org.joda.time"));
+ classesInPackage("org.joda.time"),
+ classesInPackage("org.threeten.bp"));
Review comment:
Got it. I don't think we need to make significant efforts here to wrap
client dependencies. If this becomes problematic (i.e. diamond dependency
troubles), we can consider wrapping the client or pushing on the Spanner
library to encapsulate the dependency instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 197047)
Time Spent: 2h (was: 1h 50m)
> Update GCP dependencies to a recent version
> -------------------------------------------
>
> Key: BEAM-6628
> URL: https://issues.apache.org/jira/browse/BEAM-6628
> Project: Beam
> Issue Type: Task
> Components: io-java-gcp
> Reporter: Kenneth Jung
> Priority: Minor
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Update GCP client libraries to a recent version. These libraries must be
> updated together in order to keep shared dependencies in sync.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
