[
https://issues.apache.org/jira/browse/BEAM-11659?focusedWorklogId=561664&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-561664
]
ASF GitHub Bot logged work on BEAM-11659:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Mar/21 01:30
Start Date: 06/Mar/21 01:30
Worklog Time Spent: 10m
Work Description: dpcollins-google commented on a change in pull request
#13980:
URL: https://github.com/apache/beam/pull/13980#discussion_r588809756
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubMessage.java
##########
@@ -31,51 +31,68 @@
"nullness" // TODO(https://issues.apache.org/jira/browse/BEAM-10402)
})
public class PubsubMessage {
+ @AutoValue
+ abstract static class Impl {
+ @SuppressWarnings("mutable")
+ abstract byte[] getPayload();
- private byte[] message;
- private @Nullable Map<String, String> attributes;
- private @Nullable String messageId;
+ abstract @Nullable Map<String, String> getAttributeMap();
+
+ abstract @Nullable String getMessageId();
+
+ static Impl create(
+ byte[] payload, @Nullable Map<String, String> attributes, @Nullable
String messageId) {
+ return new AutoValue_PubsubMessage_Impl(payload, attributes, messageId);
+ }
+ }
+
+ private Impl impl;
Review comment:
Yes, thats exactly what its for. This can't be changed to an AutoValue
class without an API break as it has constructors, but we can implement these
methods in an automated fashion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 561664)
Time Spent: 21.5h (was: 21h 20m)
> Integrate Pub/Sub Lite with beam SQL
> ------------------------------------
>
> Key: BEAM-11659
> URL: https://issues.apache.org/jira/browse/BEAM-11659
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql, io-java-gcp
> Reporter: Daniel Collins
> Assignee: Daniel Collins
> Priority: P2
> Time Spent: 21.5h
> Remaining Estimate: 0h
>
> Pub/Sub Lite should be a valid source and sink for beam SQL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
