[
https://issues.apache.org/jira/browse/BEAM-11659?focusedWorklogId=561690&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-561690
]
ASF GitHub Bot logged work on BEAM-11659:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Mar/21 02:22
Start Date: 06/Mar/21 02:22
Worklog Time Spent: 10m
Work Description: dpcollins-google commented on a change in pull request
#13980:
URL: https://github.com/apache/beam/pull/13980#discussion_r588817540
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubSchemaIOProvider.java
##########
@@ -206,17 +211,18 @@ public Schema schema() {
return new PTransform<PBegin, PCollection<Row>>() {
@Override
public PCollection<Row> expand(PBegin begin) {
+ PubsubMessageToRow.Builder builder =
+ PubsubMessageToRow.builder()
+ .messageSchema(dataSchema)
+ .useDlq(config.useDeadLetterQueue())
+ .useFlatSchema(useFlatSchema);
+ if (!useFlatSchema && !fieldPresent(schema(), PAYLOAD_FIELD,
FieldType.BYTES)) {
Review comment:
fixed, thanks for catching!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 561690)
Time Spent: 21h 50m (was: 21h 40m)
> Integrate Pub/Sub Lite with beam SQL
> ------------------------------------
>
> Key: BEAM-11659
> URL: https://issues.apache.org/jira/browse/BEAM-11659
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql, io-java-gcp
> Reporter: Daniel Collins
> Assignee: Daniel Collins
> Priority: P2
> Time Spent: 21h 50m
> Remaining Estimate: 0h
>
> Pub/Sub Lite should be a valid source and sink for beam SQL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
