[
https://issues.apache.org/jira/browse/BEAM-11747?focusedWorklogId=566592&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566592
]
ASF GitHub Bot logged work on BEAM-11747:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Mar/21 22:33
Start Date: 15/Mar/21 22:33
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #14241:
URL: https://github.com/apache/beam/pull/14241#discussion_r594728310
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLQueryPlanner.java
##########
@@ -174,29 +174,20 @@ static boolean hasOnlyJavaUdfInProjects(RelOptRuleCall x)
{
} else if (rexNode instanceof RexLiteral) {
SqlTypeName typeName = ((RexLiteral) rexNode).getTypeName();
switch (typeName) {
- case NULL:
- case BOOLEAN:
- case CHAR:
- case BINARY:
- case DECIMAL:
- break;
- default:
- // Reject unsupported literals
+ case BIGINT: // BEAM-11989
+ case DATE: // BEAM-11990
return false;
+ default:
+ break;
}
} else if (rexNode instanceof RexInputRef) {
SqlTypeName typeName = ((RexInputRef)
rexNode).getType().getSqlTypeName();
switch (typeName) {
- case BIGINT:
- case DOUBLE:
- case BOOLEAN:
- case VARCHAR:
- case VARBINARY:
- case DECIMAL:
- break;
- default:
- // Reject unsupported input ref
+ case BIGINT: // BEAM-11989
Review comment:
BigInt was actually in the supported types for InputRef before...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 566592)
Time Spent: 12h 10m (was: 12h)
> Reject the mixed Java UDF and ZetaSQL builtin operators cases
> --------------------------------------------------------------
>
> Key: BEAM-11747
> URL: https://issues.apache.org/jira/browse/BEAM-11747
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql-zetasql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: P2
> Time Spent: 12h 10m
> Remaining Estimate: 0h
>
> Before we have Calc splitting implemented, we can reject the mixed Java UDF
> and ZetaSQL builtin operators cases to maintain the correctness of a query.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
