[
https://issues.apache.org/jira/browse/BEAM-11747?focusedWorklogId=568670&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-568670
]
ASF GitHub Bot logged work on BEAM-11747:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/21 23:01
Start Date: 18/Mar/21 23:01
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #14241:
URL: https://github.com/apache/beam/pull/14241#discussion_r597298103
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLQueryPlanner.java
##########
@@ -174,28 +174,39 @@ static boolean hasOnlyJavaUdfInProjects(RelOptRuleCall x)
{
} else if (rexNode instanceof RexLiteral) {
SqlTypeName typeName = ((RexLiteral) rexNode).getTypeName();
switch (typeName) {
- case NULL:
+ case DOUBLE:
case BOOLEAN:
- case CHAR:
- case BINARY:
+ case VARCHAR:
Review comment:
I was under the impression that null string should be treated as `NULL`,
but I might be wrong here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 568670)
Time Spent: 13h (was: 12h 50m)
> Reject the mixed Java UDF and ZetaSQL builtin operators cases
> --------------------------------------------------------------
>
> Key: BEAM-11747
> URL: https://issues.apache.org/jira/browse/BEAM-11747
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql-zetasql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: P2
> Time Spent: 13h
> Remaining Estimate: 0h
>
> Before we have Calc splitting implemented, we can reject the mixed Java UDF
> and ZetaSQL builtin operators cases to maintain the correctness of a query.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
