[
https://issues.apache.org/jira/browse/BEAM-11868?focusedWorklogId=567409&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-567409
]
ASF GitHub Bot logged work on BEAM-11868:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Mar/21 03:27
Start Date: 17/Mar/21 03:27
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#14060:
URL: https://github.com/apache/beam/pull/14060#discussion_r595686327
##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -2364,6 +2364,22 @@ def from_runner_api_parameter(
def runner_api_requires_keyed_input(self):
return True
+ def get_windowing(self, inputs):
+ # Circular dep, because trigger pulls in CombineFn
+ from apache_beam.transforms.trigger import AfterProcessingTime
Review comment:
Wow, I really must have written this in a hurry. Of course you are
right. In Java every trigger has a continuation trigger and it is evaluated by
a visitor:
https://github.com/apache/beam/blob/4ff08fea21fb79200cd47d1e887b24568a644f7c/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Trigger.java#L103
Gonna convert this back to a draft and do it right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 567409)
Time Spent: 2h 50m (was: 2h 40m)
> Python AfterProcessingTime triggers result in additional delay at each GBK
> --------------------------------------------------------------------------
>
> Key: BEAM-11868
> URL: https://issues.apache.org/jira/browse/BEAM-11868
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: P2
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> See thread discussing it:
> https://lists.apache.org/thread.html/rd1b59fead3927b8769514f65fa66c051f80f68a6115dae356e86302c%40%3Cdev.beam.apache.org%3E
> The solution is to switch to match Java and have
> "AfterSynchronizedProcessingTime" but also to allow a runner to ignore that
> trigger and do whatever it wants.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
