[
https://issues.apache.org/jira/browse/BEAM-11868?focusedWorklogId=567446&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-567446
]
ASF GitHub Bot logged work on BEAM-11868:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Mar/21 06:22
Start Date: 17/Mar/21 06:22
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #14060:
URL: https://github.com/apache/beam/pull/14060#issuecomment-784832026
# [Codecov](https://codecov.io/gh/apache/beam/pull/14060?src=pr&el=h1) Report
> Merging
[#14060](https://codecov.io/gh/apache/beam/pull/14060?src=pr&el=desc) (4ff08fe)
into
[master](https://codecov.io/gh/apache/beam/commit/2b8938eced3b5776441246f521a38af5269f916a?el=desc)
(2b8938e) will **increase** coverage by `0.30%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 4ff08fe differs from pull request most recent
head 5c924e5. Consider uploading reports for the commit 5c924e5 to get more
accurate results
[](https://codecov.io/gh/apache/beam/pull/14060?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14060 +/- ##
==========================================
+ Coverage 83.05% 83.35% +0.30%
==========================================
Files 469 468 -1
Lines 58473 58800 +327
==========================================
+ Hits 48563 49012 +449
+ Misses 9910 9788 -122
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/14060?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[.../runners/interactive/testing/test\_cache\_manager.py](https://codecov.io/gh/apache/beam/pull/14060/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL3Rlc3RfY2FjaGVfbWFuYWdlci5weQ==)
| `91.30% <0.00%> (-2.90%)` | :arrow_down: |
|
[.../internal/clients/dataflow/dataflow\_v1b3\_client.py](https://codecov.io/gh/apache/beam/pull/14060/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9jbGllbnRzL2RhdGFmbG93L2RhdGFmbG93X3YxYjNfY2xpZW50LnB5)
| `71.34% <0.00%> (-1.47%)` | :arrow_down: |
|
[...cs/sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/14060/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=)
| `88.73% <0.00%> (-1.36%)` | :arrow_down: |
|
[...srcs/sdks/python/apache\_beam/coders/avro\_record.py](https://codecov.io/gh/apache/beam/pull/14060/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2F2cm9fcmVjb3JkLnB5)
| `88.88% <0.00%> (-1.12%)` | :arrow_down: |
|
[...cs/sdks/python/apache\_beam/dataframe/frame\_base.py](https://codecov.io/gh/apache/beam/pull/14060/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lX2Jhc2UucHk=)
| `89.65% <0.00%> (-0.85%)` | :arrow_down: |
|
[...on/apache\_beam/runners/portability/spark\_runner.py](https://codecov.io/gh/apache/beam/pull/14060/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zcGFya19ydW5uZXIucHk=)
| `55.81% <0.00%> (-0.71%)` | :arrow_down: |
|
[...ks/python/apache\_beam/coders/coders\_test\_common.py](https://codecov.io/gh/apache/beam/pull/14060/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVyc190ZXN0X2NvbW1vbi5weQ==)
| `98.31% <0.00%> (-0.59%)` | :arrow_down: |
|
[.../srcs/sdks/python/apache\_beam/dataframe/convert.py](https://codecov.io/gh/apache/beam/pull/14060/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2NvbnZlcnQucHk=)
| `90.36% <0.00%> (-0.55%)` | :arrow_down: |
|
[...on/apache\_beam/runners/portability/flink\_runner.py](https://codecov.io/gh/apache/beam/pull/14060/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbGlua19ydW5uZXIucHk=)
| `61.11% <0.00%> (-0.30%)` | :arrow_down: |
|
[...on/apache\_beam/runners/dataflow/dataflow\_runner.py](https://codecov.io/gh/apache/beam/pull/14060/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXIucHk=)
| `81.63% <0.00%> (-0.26%)` | :arrow_down: |
| ... and [51
more](https://codecov.io/gh/apache/beam/pull/14060/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/14060?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/14060?src=pr&el=footer). Last
update
[2b8938e...5c924e5](https://codecov.io/gh/apache/beam/pull/14060?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 567446)
Time Spent: 3h (was: 2h 50m)
> Python AfterProcessingTime triggers result in additional delay at each GBK
> --------------------------------------------------------------------------
>
> Key: BEAM-11868
> URL: https://issues.apache.org/jira/browse/BEAM-11868
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: P2
> Time Spent: 3h
> Remaining Estimate: 0h
>
> See thread discussing it:
> https://lists.apache.org/thread.html/rd1b59fead3927b8769514f65fa66c051f80f68a6115dae356e86302c%40%3Cdev.beam.apache.org%3E
> The solution is to switch to match Java and have
> "AfterSynchronizedProcessingTime" but also to allow a runner to ignore that
> trigger and do whatever it wants.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
