[
https://issues.apache.org/jira/browse/BEAM-11914?focusedWorklogId=567813&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-567813
]
ASF GitHub Bot logged work on BEAM-11914:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Mar/21 16:46
Start Date: 17/Mar/21 16:46
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#14155:
URL: https://github.com/apache/beam/pull/14155#discussion_r596201351
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java
##########
@@ -91,6 +91,16 @@
*/
public abstract class DoFn<InputT extends @Nullable Object, OutputT extends
@Nullable Object>
implements Serializable, HasDisplayData {
+ /** Information accessible while within the {@link Setup} method. */
+ @SuppressWarnings("ClassCanBeStatic") // Converting class to static is an
API change.
+ public abstract class SetupContext {
Review comment:
I mean you would call `invokeSetup` with an `ArgumentProvider` that
provides the options (this already exists). Then the job of the invoker
(generated bytecode) is to pass the right arguments to the DoFn.
Basically: no more contexts passed to annotation-style `DoFn`s. In fact, we
should deprecate the existing ones. Instead, `ArgumentProvider` is basically
the same thing, but only passed to `DoFnInvoker` and the invoker passes just
the arguments needed to the `DoFn`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 567813)
Time Spent: 1h (was: 50m)
> Add PipelineOptions as DoFn @Setup parameters
> ---------------------------------------------
>
> Key: BEAM-11914
> URL: https://issues.apache.org/jira/browse/BEAM-11914
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Xinyu Liu
> Assignee: Xinyu Liu
> Priority: P2
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Passing PipelineOptions to DoFn @Setup makes it easier for the users to
> access their pipeline arguments. It also allows dynamically creating
> PipelineOptions while constructing the pipeline, and can benefit integration
> with other config management framework.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
