[
https://issues.apache.org/jira/browse/BEAM-11914?focusedWorklogId=568706&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-568706
]
ASF GitHub Bot logged work on BEAM-11914:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/21 00:58
Start Date: 19/Mar/21 00:58
Worklog Time Spent: 10m
Work Description: xinyuiscool commented on a change in pull request
#14155:
URL: https://github.com/apache/beam/pull/14155#discussion_r597338571
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java
##########
@@ -91,6 +91,16 @@
*/
public abstract class DoFn<InputT extends @Nullable Object, OutputT extends
@Nullable Object>
implements Serializable, HasDisplayData {
+ /** Information accessible while within the {@link Setup} method. */
+ @SuppressWarnings("ClassCanBeStatic") // Converting class to static is an
API change.
+ public abstract class SetupContext {
Review comment:
Makes sense. The explicit parameters in the args does make static
analysis and validation possible. I agree there is no need to have a
SetupContext. Updated the patch to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 568706)
Time Spent: 1.5h (was: 1h 20m)
> Add PipelineOptions as DoFn @Setup parameters
> ---------------------------------------------
>
> Key: BEAM-11914
> URL: https://issues.apache.org/jira/browse/BEAM-11914
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Xinyu Liu
> Assignee: Xinyu Liu
> Priority: P2
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Passing PipelineOptions to DoFn @Setup makes it easier for the users to
> access their pipeline arguments. It also allows dynamically creating
> PipelineOptions while constructing the pipeline, and can benefit integration
> with other config management framework.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
