[
https://issues.apache.org/jira/browse/BEAM-12069?focusedWorklogId=573747&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-573747
]
ASF GitHub Bot logged work on BEAM-12069:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Mar/21 22:12
Start Date: 29/Mar/21 22:12
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#14328:
URL: https://github.com/apache/beam/pull/14328#discussion_r603643643
##########
File path: sdks/python/setup.py
##########
@@ -146,7 +146,7 @@ def get_version():
'grpcio>=1.29.0,<2',
'hdfs>=2.1.0,<3.0.0',
'httplib2>=0.8,<0.18.0',
- 'mock>=1.0.1,<3.0.0',
Review comment:
Thanks @potiuk, good to know this will help airflow as well :)
I filed BEAM-12069 to track the issue fixed by this PR, BEAM-11167 would be
the appropriate jira for the dill issue. I don't think there's any reason not
to go ahead and upgrade it, we just have it pinned to a narrow range to avoid
compatibility issues (e.g. see BEAM-4785). Would you be interested in trying to
upgrade dill to 0.3.2 or 0.3.3?
##########
File path: sdks/python/setup.py
##########
@@ -167,6 +166,7 @@ def get_version():
REQUIRED_TEST_PACKAGES = [
'freezegun>=0.3.12',
+ 'mock>=1.0.1',
Review comment:
```suggestion
'mock>=1.0.1<3.0.0',
```
Let's keep the upper bound for now to minimize the diff. Just making it a
test dependency should address the TF
and airflow issues. Updating the dep is tracked separately in BEAM-7369.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 573747)
Remaining Estimate: 0h
Time Spent: 10m
> mock should be a test dependency
> --------------------------------
>
> Key: BEAM-12069
> URL: https://issues.apache.org/jira/browse/BEAM-12069
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
> mock is a mocking framework used in tests, but we have it listed as a hard
> dependency. This seems to be because it predates when we started separating
> out test dependencies.
> We should make it a test-only dependency.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
