[
https://issues.apache.org/jira/browse/BEAM-12069?focusedWorklogId=574968&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-574968
]
ASF GitHub Bot logged work on BEAM-12069:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Mar/21 16:28
Start Date: 31/Mar/21 16:28
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #14328:
URL: https://github.com/apache/beam/pull/14328#discussion_r605045781
##########
File path: sdks/python/setup.py
##########
@@ -146,7 +146,7 @@ def get_version():
'grpcio>=1.29.0,<2',
'hdfs>=2.1.0,<3.0.0',
'httplib2>=0.8,<0.18.0',
- 'mock>=1.0.1,<3.0.0',
Review comment:
I think it is fine to upgrade dill. Although we will still need a very
narrow range for dill for this reason:
https://github.com/apache/beam/blob/master/sdks/python/setup.py#L138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 574968)
Time Spent: 2h 10m (was: 2h)
> mock should be a test dependency
> --------------------------------
>
> Key: BEAM-12069
> URL: https://issues.apache.org/jira/browse/BEAM-12069
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Amy Wu
> Priority: P2
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> mock is a mocking framework used in tests, but we have it listed as a hard
> dependency. This seems to be because it predates when we started separating
> out test dependencies.
> We should make it a test-only dependency.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
