[ 
https://issues.apache.org/jira/browse/BEAM-12069?focusedWorklogId=574996&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-574996
 ]

ASF GitHub Bot logged work on BEAM-12069:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Mar/21 17:25
            Start Date: 31/Mar/21 17:25
    Worklog Time Spent: 10m 
      Work Description: codecov[bot] edited a comment on pull request #14389:
URL: https://github.com/apache/beam/pull/14389#issuecomment-811250842


   # [Codecov](https://codecov.io/gh/apache/beam/pull/14389?src=pr&el=h1) Report
   > Merging 
[#14389](https://codecov.io/gh/apache/beam/pull/14389?src=pr&el=desc) (dd99414) 
into 
[master](https://codecov.io/gh/apache/beam/commit/93a6927db771208bd74ede940ce6ba2d24684ccb?el=desc)
 (93a6927) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/beam/pull/14389/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/14389?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14389      +/-   ##
   ==========================================
   - Coverage   83.45%   83.44%   -0.01%     
   ==========================================
     Files         470      470              
     Lines       59001    59001              
   ==========================================
   - Hits        49239    49236       -3     
   - Misses       9762     9765       +3     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/beam/pull/14389?src=pr&el=tree) | Coverage 
Δ | |
   |---|---|---|
   | 
[...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/14389/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2RpcmVjdC90ZXN0X3N0cmVhbV9pbXBsLnB5)
 | `91.91% <0.00%> (-2.21%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/beam/pull/14389?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/beam/pull/14389?src=pr&el=footer). Last 
update 
[288d379...dd99414](https://codecov.io/gh/apache/beam/pull/14389?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 574996)
    Time Spent: 3.5h  (was: 3h 20m)

> mock should be a test dependency
> --------------------------------
>
>                 Key: BEAM-12069
>                 URL: https://issues.apache.org/jira/browse/BEAM-12069
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core
>            Reporter: Brian Hulette
>            Assignee: Amy Wu
>            Priority: P2
>          Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> mock is a mocking framework used in tests, but we have it listed as a hard 
> dependency. This seems to be because it predates when we started separating 
> out test dependencies.
> We should make it a test-only dependency.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to