[
https://issues.apache.org/jira/browse/BEAM-12029?focusedWorklogId=582971&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582971
]
ASF GitHub Bot logged work on BEAM-12029:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Apr/21 22:21
Start Date: 14/Apr/21 22:21
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #14517:
URL: https://github.com/apache/beam/pull/14517#issuecomment-819885781
@pabloem Doh! I'm sorry I just pushed several more commits to this branch to
add support for all the other types of WontImplementErrors that we raise.
Blurgh, I should've checked if you'd already reviewed before doing that
What you reviewed was essentially up to 5cb51b2, but I also modified those
commits a little bit to handle some more cases I found, I'm not sure I can get
the PR back to the state that you reviewed...
Would you mind taking a look at the new changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 582971)
Time Spent: 1.5h (was: 1h 20m)
> WontImplementErrors should reference offending operation or argument and link
> to documentation
> ----------------------------------------------------------------------------------------------
>
> Key: BEAM-12029
> URL: https://issues.apache.org/jira/browse/BEAM-12029
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> For example, instead of WontImplementError(order-sensitive) we should raise:
> {code}
> WontImplementError("fillna(method=ffill) is not supported because it
> order-sensitive, only fillna(method=None) is supported. For more details see
> https://s.apache.org/dataframe-order-sensitive-operations";)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
