[
https://issues.apache.org/jira/browse/BEAM-12029?focusedWorklogId=582996&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582996
]
ASF GitHub Bot logged work on BEAM-12029:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Apr/21 22:59
Start Date: 14/Apr/21 22:59
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #14517:
URL: https://github.com/apache/beam/pull/14517#discussion_r613638935
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -1393,9 +1430,16 @@ def fill_dataframe(*args):
- cummax = cummin = cumsum = cumprod = frame_base.wont_implement_method(
- 'order-sensitive')
- diff = frame_base.wont_implement_method('order-sensitive')
+ cummax = frame_base.order_sensitive_method(pd.DataFrame, 'cummax')
+ cummin = frame_base.order_sensitive_method(pd.DataFrame, 'cummin')
+ cumprod = frame_base.order_sensitive_method(pd.DataFrame, 'cumprod')
+ cumsum = frame_base.order_sensitive_method(pd.DataFrame, 'cumsum')
+ diff = frame_base.order_sensitive_method(pd.DataFrame, 'diff')
Review comment:
hmmm I see... I was thinking that you would do `index = index - 1` on
the DF, and then operate the result against the original DF, but this is not
possible because indices are not necessarily integers, and may not be sorted
integers either, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 582996)
Time Spent: 2h 10m (was: 2h)
> WontImplementErrors should reference offending operation or argument and link
> to documentation
> ----------------------------------------------------------------------------------------------
>
> Key: BEAM-12029
> URL: https://issues.apache.org/jira/browse/BEAM-12029
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> For example, instead of WontImplementError(order-sensitive) we should raise:
> {code}
> WontImplementError("fillna(method=ffill) is not supported because it
> order-sensitive, only fillna(method=None) is supported. For more details see
> https://s.apache.org/dataframe-order-sensitive-operations";)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
