[
https://issues.apache.org/jira/browse/BEAM-4775?focusedWorklogId=200916&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-200916
]
ASF GitHub Bot logged work on BEAM-4775:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Feb/19 22:01
Start Date: 19/Feb/19 22:01
Worklog Time Spent: 10m
Work Description: ryan-williams commented on issue #7867: [BEAM-4775] key
MetricResult by a MetricKey
URL: https://github.com/apache/beam/pull/7867#issuecomment-465328868
Thanks Alex. The good news is I think we agree about everything you've said.
In #7823 I basically turn the existing Java SDK metrics classes into
wrappers for corresponding MonitoringInfo structures:
- `MetricKey`: {URN, labels}
- `MetricName`: URN
- I basically folded `MonitoringInfoMetricName` into `MetricName`, which
becomes the only implementation of that concept
- `MetricLabels`: labels map
- thin wrapper over the raw map, that also exposes some APIs that encode
the fact that today we expect MonitoringInfos to have exactly one of
{`PTRANSFORM`,`PCOLLECTION`}.
So that is the larger vision, which this PR is a small step toward. LMK if
that sounds off to you. I'm in a constant process of pulling stuff out of #7823
so that the real work will be in clearer relief there.
A different question that [came up with @mxm on
#7866](https://github.com/apache/beam/pull/7866#issuecomment-465241925) is
around what packages things should live in. I don't think it's too bad if
`MetricKey` goes into java/core here, but where it gets complicated is that
inevitably, MetricResult → MetricKey → {fn-api protos}, which adds [java/core →
model-fn-execution], which gives me some pause.
Hopefully we can push on other parts of this (and related PRs) while I think
more about that question. Ofc any thoughts are welcome.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 200916)
Time Spent: 9h (was: 8h 50m)
> JobService should support returning metrics
> -------------------------------------------
>
> Key: BEAM-4775
> URL: https://issues.apache.org/jira/browse/BEAM-4775
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Eugene Kirpichov
> Assignee: Ryan Williams
> Priority: Major
> Labels: triaged
> Time Spent: 9h
> Remaining Estimate: 0h
>
> [https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_job_api.proto]
> currently doesn't appear to have a way for JobService to return metrics to a
> user, even though
> [https://github.com/apache/beam/blob/master/model/fn-execution/src/main/proto/beam_fn_api.proto]
> includes support for reporting SDK metrics to the runner harness.
>
> Metrics are apparently necessary to run any ValidatesRunner tests because
> PAssert needs to validate that the assertions succeeded. However, this
> statement should be double-checked: perhaps it's possible to somehow work
> with PAssert without metrics support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
