[
https://issues.apache.org/jira/browse/BEAM-4775?focusedWorklogId=200931&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-200931
]
ASF GitHub Bot logged work on BEAM-4775:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Feb/19 22:15
Start Date: 19/Feb/19 22:15
Worklog Time Spent: 10m
Work Description: ajamato commented on pull request #7868: [BEAM-4775]
MonitoringInfo URN tweaks
URL: https://github.com/apache/beam/pull/7868#discussion_r258248278
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -311,13 +311,13 @@ message ProcessBundleProgressRequest {
string instruction_reference = 1;
}
-// A specification containing required set of fields and labels required
-// to be set on a MonitoringInfo for the specific URN for SDK->RunnerHarness
+// A specification containing required set of fields and labels required to be
+// set on a MonitoringInfo for a given URN-type, for SDK->RunnerHarness
Review comment:
That's not correct. The specific URN has a set of required field.
ElementCount has a PCollection.
ExecutionTimes have a PTransform.
URN-type refers to the value type. counter int64, counter double, gauge
string, gauge int64, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 200931)
Time Spent: 9h 40m (was: 9.5h)
> JobService should support returning metrics
> -------------------------------------------
>
> Key: BEAM-4775
> URL: https://issues.apache.org/jira/browse/BEAM-4775
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Eugene Kirpichov
> Assignee: Ryan Williams
> Priority: Major
> Labels: triaged
> Time Spent: 9h 40m
> Remaining Estimate: 0h
>
> [https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_job_api.proto]
> currently doesn't appear to have a way for JobService to return metrics to a
> user, even though
> [https://github.com/apache/beam/blob/master/model/fn-execution/src/main/proto/beam_fn_api.proto]
> includes support for reporting SDK metrics to the runner harness.
>
> Metrics are apparently necessary to run any ValidatesRunner tests because
> PAssert needs to validate that the assertions succeeded. However, this
> statement should be double-checked: perhaps it's possible to somehow work
> with PAssert without metrics support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
