[
https://issues.apache.org/jira/browse/BEAM-4775?focusedWorklogId=200963&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-200963
]
ASF GitHub Bot logged work on BEAM-4775:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Feb/19 23:06
Start Date: 19/Feb/19 23:06
Worklog Time Spent: 10m
Work Description: ryan-williams commented on issue #7823: [DO NOT MERGE]
[BEAM-4775] Second take on portable metrics over the job-server API
URL: https://github.com/apache/beam/pull/7823#issuecomment-465348737
> I'm not sure if you want me to review this one or not. This PR is a bit
massive.
Yea, there are probably 4 chunks I will still pull out of this into separate
PRs, that are hopefully more manageable:
- consolidating MetricResult implementations
- already out at #7890, though I need to fix a couple tests
- I haven't had a chance to factor those changes out of this PR yet
- fully supporting MonitoringInfo data types ({URN, labels}) inside
`MetricKey` (comprised of `MetricName`,`MetricLabels`)
- adding the job-API metrics RPC
- python support
In the meantime, [this link will show all the changes that still live only
in this
PR](https://github.com/ryan-williams/beam/compare/octo...ryan-williams:mk);
this PR's main view still displays all the changes it is rebased on top of.
> Is this the one that introduces the new layer to extract the new
MonitoringInfo metrics over an RPC?
https://s.apache.org/get-metrics-api
Yea, that is in here! Swimming to the surface…
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 200963)
Time Spent: 12h 10m (was: 12h)
> JobService should support returning metrics
> -------------------------------------------
>
> Key: BEAM-4775
> URL: https://issues.apache.org/jira/browse/BEAM-4775
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Eugene Kirpichov
> Assignee: Ryan Williams
> Priority: Major
> Labels: triaged
> Time Spent: 12h 10m
> Remaining Estimate: 0h
>
> [https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_job_api.proto]
> currently doesn't appear to have a way for JobService to return metrics to a
> user, even though
> [https://github.com/apache/beam/blob/master/model/fn-execution/src/main/proto/beam_fn_api.proto]
> includes support for reporting SDK metrics to the runner harness.
>
> Metrics are apparently necessary to run any ValidatesRunner tests because
> PAssert needs to validate that the assertions succeeded. However, this
> statement should be double-checked: perhaps it's possible to somehow work
> with PAssert without metrics support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
