[
https://issues.apache.org/jira/browse/BEAM-4775?focusedWorklogId=200955&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-200955
]
ASF GitHub Bot logged work on BEAM-4775:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Feb/19 22:54
Start Date: 19/Feb/19 22:54
Worklog Time Spent: 10m
Work Description: ajamato commented on pull request #7876: [BEAM-4775]
Clean up metric protos; support integer distributions, gauges
URL: https://github.com/apache/beam/pull/7876#discussion_r258264884
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/metrics/FlinkMetricContainer.java
##########
@@ -94,121 +93,128 @@ public MetricsContainer getMetricsContainer(String
stepName) {
: null;
}
+ public MetricsContainer getUnboundMetricsContainer() {
+ return metricsAccumulator != null
+ ? metricsAccumulator.getLocalValue().getUnboundContainer()
+ : null;
+ }
+
/**
* Update this container with metrics from the passed {@link
MonitoringInfo}s, and send updates
* along to Flink's internal metrics framework.
*/
- public void updateMetrics(String stepName, List<MonitoringInfo>
monitoringInfos) {
- MetricsContainer metricsContainer = getMetricsContainer(stepName);
+ public void updateMetrics(List<MonitoringInfo> monitoringInfos) {
Review comment:
Question about the overall design here. Much of this class doesn't seem
flink specific. If its just aggregating the values in memory, perhaps it should
just aggregate the MonitoringInfos. Then have some method to extract them in a
flink specific format (possibly in another class)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 200955)
Time Spent: 11h 20m (was: 11h 10m)
> JobService should support returning metrics
> -------------------------------------------
>
> Key: BEAM-4775
> URL: https://issues.apache.org/jira/browse/BEAM-4775
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Eugene Kirpichov
> Assignee: Ryan Williams
> Priority: Major
> Labels: triaged
> Time Spent: 11h 20m
> Remaining Estimate: 0h
>
> [https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_job_api.proto]
> currently doesn't appear to have a way for JobService to return metrics to a
> user, even though
> [https://github.com/apache/beam/blob/master/model/fn-execution/src/main/proto/beam_fn_api.proto]
> includes support for reporting SDK metrics to the runner harness.
>
> Metrics are apparently necessary to run any ValidatesRunner tests because
> PAssert needs to validate that the assertions succeeded. However, this
> statement should be double-checked: perhaps it's possible to somehow work
> with PAssert without metrics support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
