[
https://issues.apache.org/jira/browse/BEAM-4775?focusedWorklogId=201420&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-201420
]
ASF GitHub Bot logged work on BEAM-4775:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/19 16:31
Start Date: 20/Feb/19 16:31
Worklog Time Spent: 10m
Work Description: ryan-williams commented on pull request #7866:
[BEAM-4775] mv function pkg from fn-harness to java-core
URL: https://github.com/apache/beam/pull/7866#discussion_r258566571
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/function/ThrowingConsumer.java
##########
@@ -26,6 +26,6 @@
* interfaces.
*/
@FunctionalInterface
-public interface ThrowingConsumer<T> {
- void accept(T t) throws Exception;
+public interface ThrowingConsumer<ExceptionT extends Exception, T> {
+ void accept(T t) throws ExceptionT;
Review comment:
There was a note at the end of [this
comment](https://github.com/apache/beam/pull/7866#issuecomment-465241925) about
that part.
It's not used here, but I do have [a motivating case for a
`ThrowingConsumer<IOException,
T>`](https://github.com/apache/beam/pull/7823/files#diff-1677e5001d798d26293b99815a5c16d8R114)
in #7823.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 201420)
Time Spent: 15h 50m (was: 15h 40m)
> JobService should support returning metrics
> -------------------------------------------
>
> Key: BEAM-4775
> URL: https://issues.apache.org/jira/browse/BEAM-4775
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Eugene Kirpichov
> Assignee: Ryan Williams
> Priority: Major
> Labels: triaged
> Time Spent: 15h 50m
> Remaining Estimate: 0h
>
> [https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_job_api.proto]
> currently doesn't appear to have a way for JobService to return metrics to a
> user, even though
> [https://github.com/apache/beam/blob/master/model/fn-execution/src/main/proto/beam_fn_api.proto]
> includes support for reporting SDK metrics to the runner harness.
>
> Metrics are apparently necessary to run any ValidatesRunner tests because
> PAssert needs to validate that the assertions succeeded. However, this
> statement should be double-checked: perhaps it's possible to somehow work
> with PAssert without metrics support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
