[
https://issues.apache.org/jira/browse/BEAM-4775?focusedWorklogId=201453&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-201453
]
ASF GitHub Bot logged work on BEAM-4775:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/19 17:17
Start Date: 20/Feb/19 17:17
Worklog Time Spent: 10m
Work Description: ryan-williams commented on issue #7866: [BEAM-4775] mv
function pkg from fn-harness to java-core
URL: https://github.com/apache/beam/pull/7866#issuecomment-465672234
I think this can be decoupled from metrics/module concerns, and is good to
go, if you agree that java/core is a more logical place for such generic
language-level helpers.
Even if the metrics code that uses it ends up somewhere higher-up than
java/core, having it depend on these helpers in java/core seems reasonable.
Pulling things like this back out of java/core to dedicated packages later
seems fine and good as well, if necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 201453)
Time Spent: 17h (was: 16h 50m)
> JobService should support returning metrics
> -------------------------------------------
>
> Key: BEAM-4775
> URL: https://issues.apache.org/jira/browse/BEAM-4775
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Eugene Kirpichov
> Assignee: Ryan Williams
> Priority: Major
> Labels: triaged
> Time Spent: 17h
> Remaining Estimate: 0h
>
> [https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_job_api.proto]
> currently doesn't appear to have a way for JobService to return metrics to a
> user, even though
> [https://github.com/apache/beam/blob/master/model/fn-execution/src/main/proto/beam_fn_api.proto]
> includes support for reporting SDK metrics to the runner harness.
>
> Metrics are apparently necessary to run any ValidatesRunner tests because
> PAssert needs to validate that the assertions succeeded. However, this
> statement should be double-checked: perhaps it's possible to somehow work
> with PAssert without metrics support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
