[
https://issues.apache.org/jira/browse/BEAM-6714?focusedWorklogId=201631&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-201631
]
ASF GitHub Bot logged work on BEAM-6714:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/19 21:49
Start Date: 20/Feb/19 21:49
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #7907: [BEAM-6714] Move
runner-agnostic code out of FlinkJobServerDriver
URL: https://github.com/apache/beam/pull/7907
I moved runner-agnostic code in `FlinkJobServerDriver` to the new abstract
class `JobServerDriver`, which can be reused by other portable runners going
forward.
I did *not* make any changes to `SamzaJobServerDriver` yet, but it might be
a good idea to adapt `SamzaJobServerDriver` to extend `JobServerDriver`. As far
as I can tell, the former only includes a subset of the latter's features.
R: @angoenka
R: @robertwb
------------------------
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
See [.test-infra/jenkins/README](../.test-infra/jenkins/README.md) for
trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 201631)
Time Spent: 10m
Remaining Estimate: 0h
> Move runner-agnostic code out of FlinkJobServerDriver
> -----------------------------------------------------
>
> Key: BEAM-6714
> URL: https://issues.apache.org/jira/browse/BEAM-6714
> Project: Beam
> Issue Type: Task
> Components: runner-flink, runner-samza, runner-spark
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> [FlinkJobServerDriver|https://github.com/apache/beam/blob/master/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkJobServerDriver.java]
> contains quite a bit of code that is not actually specific to the Flink
> runner. This runner-agnostic code should be shared so that other runners (ie
> Spark) developing portability can leverage it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
