[
https://issues.apache.org/jira/browse/BEAM-6714?focusedWorklogId=202098&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-202098
]
ASF GitHub Bot logged work on BEAM-6714:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Feb/19 17:19
Start Date: 21/Feb/19 17:19
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #7907: [BEAM-6714] Move
runner-agnostic code out of FlinkJobServerDriver
URL: https://github.com/apache/beam/pull/7907#discussion_r259030968
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/jobsubmission/JobServerDriver.java
##########
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.fnexecution.jobsubmission;
+
+import java.io.IOException;
+import java.nio.file.Paths;
+import org.apache.beam.model.pipeline.v1.Endpoints;
+import org.apache.beam.runners.fnexecution.GrpcFnServer;
+import org.apache.beam.runners.fnexecution.ServerFactory;
+import
org.apache.beam.runners.fnexecution.artifact.BeamFileSystemArtifactStagingService;
+import
org.apache.beam.vendor.guava.v20_0.com.google.common.annotations.VisibleForTesting;
+import org.kohsuke.args4j.Option;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/** Shared code for starting an {@link InMemoryJobService}. */
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 202098)
Time Spent: 1h 20m (was: 1h 10m)
> Move runner-agnostic code out of FlinkJobServerDriver
> -----------------------------------------------------
>
> Key: BEAM-6714
> URL: https://issues.apache.org/jira/browse/BEAM-6714
> Project: Beam
> Issue Type: Task
> Components: runner-flink, runner-samza, runner-spark
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> [FlinkJobServerDriver|https://github.com/apache/beam/blob/master/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkJobServerDriver.java]
> contains quite a bit of code that is not actually specific to the Flink
> runner. This runner-agnostic code should be shared so that other runners (ie
> Spark) developing portability can leverage it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
