[
https://issues.apache.org/jira/browse/BEAM-12326?focusedWorklogId=594876&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-594876
]
ASF GitHub Bot logged work on BEAM-12326:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/May/21 23:01
Start Date: 11/May/21 23:01
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #14783:
URL: https://github.com/apache/beam/pull/14783#discussion_r630593570
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -299,6 +299,9 @@ def _replace_if_needed(self, original_transform_node):
original_transform_node.full_label,
original_transform_node.inputs)
+ replacement_transform_node.resource_hints = (
+ original_transform_node.resource_hints)
Review comment:
Thanks for catching this. Would a factory method in AppliedPTransform be
a better way to generate replacement in a way that replacement doesn't lose
some important fields that will be defined later?
Also, should this preserve `environment` and `annotations` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 594876)
Time Spent: 1h 20m (was: 1h 10m)
> Resource hints not respected after transform substitution.
> ----------------------------------------------------------
>
> Key: BEAM-12326
> URL: https://issues.apache.org/jira/browse/BEAM-12326
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: P2
> Fix For: 2.30.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
