[
https://issues.apache.org/jira/browse/BEAM-12326?focusedWorklogId=594882&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-594882
]
ASF GitHub Bot logged work on BEAM-12326:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/May/21 23:11
Start Date: 11/May/21 23:11
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #14783:
URL: https://github.com/apache/beam/pull/14783#discussion_r630597433
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -299,6 +299,9 @@ def _replace_if_needed(self, original_transform_node):
original_transform_node.full_label,
original_transform_node.inputs)
+ replacement_transform_node.resource_hints = (
+ original_transform_node.resource_hints)
Review comment:
I don't think environment or annotations are used for any non-portable
runner (and it's also unclear if they should be preserved or overwritten).
Hopefully we'll be in a position to move to all-portable runners soon and we
and just get rid of all of this code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 594882)
Time Spent: 1.5h (was: 1h 20m)
> Resource hints not respected after transform substitution.
> ----------------------------------------------------------
>
> Key: BEAM-12326
> URL: https://issues.apache.org/jira/browse/BEAM-12326
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: P2
> Fix For: 2.30.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
