[
https://issues.apache.org/jira/browse/BEAM-7372?focusedWorklogId=602030&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-602030
]
ASF GitHub Bot logged work on BEAM-7372:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/May/21 00:04
Start Date: 26/May/21 00:04
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #14855:
URL: https://github.com/apache/beam/pull/14855#discussion_r639312711
##########
File path: sdks/python/gen_protos.py
##########
@@ -32,6 +29,7 @@
import sys
import time
import warnings
+from importlib import import_module
Review comment:
We probably no longer need to futurize generated code (see line 339).
Assuming new version of proto generator produces a py3-compatible code. We
could check the diff.
This can be another change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 602030)
Time Spent: 76h 40m (was: 76.5h)
> Clean up Python 2 codepaths once Beam no longer supports Python 2.
> ------------------------------------------------------------------
>
> Key: BEAM-7372
> URL: https://issues.apache.org/jira/browse/BEAM-7372
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Priority: P3
> Labels: P3
> Time Spent: 76h 40m
> Remaining Estimate: 0h
>
> There are several places in Beam where we branch based on Python version.
> Once Python 2 is no longer supported, we can remove Py2 parts of the branch.
> To find places to clean up, we can search for "Python 2", "Python 3", "Py2",
> "sys.version_info", BEAM-8371, etc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
