[ 
https://issues.apache.org/jira/browse/BEAM-7372?focusedWorklogId=603011&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-603011
 ]

ASF GitHub Bot logged work on BEAM-7372:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/May/21 13:58
            Start Date: 27/May/21 13:58
    Worklog Time Spent: 10m 
      Work Description: lazylynx commented on a change in pull request #14855:
URL: https://github.com/apache/beam/pull/14855#discussion_r640651389



##########
File path: sdks/python/gen_protos.py
##########
@@ -32,6 +29,7 @@
 import sys
 import time
 import warnings
+from importlib import import_module

Review comment:
       I tried to generate_proto_files without futurize and found that it 
causes import error with urn files.
   I'll investigate more.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 603011)
    Time Spent: 77h 20m  (was: 77h 10m)

> Clean up Python 2 codepaths once Beam no longer supports Python 2.
> ------------------------------------------------------------------
>
>                 Key: BEAM-7372
>                 URL: https://issues.apache.org/jira/browse/BEAM-7372
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Valentyn Tymofieiev
>            Priority: P3
>              Labels: P3
>          Time Spent: 77h 20m
>  Remaining Estimate: 0h
>
> There are several places in Beam where we branch based on Python version. 
> Once Python 2 is no longer supported, we can remove Py2 parts of the branch.
> To find places to clean up, we can search for "Python 2", "Python 3", "Py2", 
> "sys.version_info", BEAM-8371, etc.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to