[
https://issues.apache.org/jira/browse/BEAM-12445?focusedWorklogId=608030&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-608030
]
ASF GitHub Bot logged work on BEAM-12445:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/21 18:11
Start Date: 07/Jun/21 18:11
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #14690:
URL: https://github.com/apache/beam/pull/14690#discussion_r646830329
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_test.py
##########
@@ -809,15 +808,14 @@ def test_dofn_client_process_performs_batching(self):
fn.process(('project_id:dataset_id.table_id', {'month': 1}))
# InsertRows not called as batch size is not hit yet
- self.assertFalse(client.tabledata.InsertAll.called)
+ self.assertFalse(client.insert_rows_json.called)
Review comment:
no. The API formats everything into JSON. Other API calls use automatic
JSON conversions.
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -1312,10 +1312,11 @@ def _flush_batch(self, destination):
skip_invalid_rows=True)
self.batch_latency_metric.update((time.time() - start) * 1000)
- failed_rows = [rows[entry.index] for entry in errors]
+ failed_rows = [rows[entry['index']] for entry in errors]
Review comment:
that's right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 608030)
Remaining Estimate: 0h
Time Spent: 10m
> Move Python's BigQuery streaming insert sink to the new BigQuery api client
> ---------------------------------------------------------------------------
>
> Key: BEAM-12445
> URL: https://issues.apache.org/jira/browse/BEAM-12445
> Project: Beam
> Issue Type: Bug
> Components: io-py-gcp
> Reporter: Pablo Estrada
> Assignee: Pablo Estrada
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
