[
https://issues.apache.org/jira/browse/BEAM-12445?focusedWorklogId=608032&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-608032
]
ASF GitHub Bot logged work on BEAM-12445:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/21 18:12
Start Date: 07/Jun/21 18:12
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #14690:
URL: https://github.com/apache/beam/pull/14690#discussion_r646831126
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_test.py
##########
@@ -950,12 +943,10 @@ def store_callback(arg):
with open(file_name_2, 'w') as f:
json.dump(json_output, f)
- res = mock.Mock()
- res.insertErrors = []
Review comment:
because `insert_rows_json` returns a list of errors (empty when no
errors), and `client.tabledata.InsertAll` returns an object that contains the
list of errors within it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 608032)
Time Spent: 20m (was: 10m)
> Move Python's BigQuery streaming insert sink to the new BigQuery api client
> ---------------------------------------------------------------------------
>
> Key: BEAM-12445
> URL: https://issues.apache.org/jira/browse/BEAM-12445
> Project: Beam
> Issue Type: Bug
> Components: io-py-gcp
> Reporter: Pablo Estrada
> Assignee: Pablo Estrada
> Priority: P2
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
