[
https://issues.apache.org/jira/browse/BEAM-6731?focusedWorklogId=206157&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-206157
]
ASF GitHub Bot logged work on BEAM-6731:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/19 00:28
Start Date: 01/Mar/19 00:28
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #7947:
[BEAM-6731] Bundle Java ExpansionService with Flink JobServer
URL: https://github.com/apache/beam/pull/7947#discussion_r261441468
##########
File path: runners/java-fn-execution/build.gradle
##########
@@ -58,3 +58,30 @@ task testDocker(type: Test) {
includeCategories
"org.apache.beam.runners.fnexecution.environment.testing.NeedsDocker"
}
}
+
+task runExpansionService (type: JavaExec) {
Review comment:
IIUC java-fn-execution module is for runner specific code related to Fn API
execution (job submission to job server, work execution) while
core-construction-java contains code related to pipeline construction before
submitting job to a runner, right ?
If so, I'm not sure if moving expansion service to the java-fn-execution
module is the correct move. It might be weird (or impossible) to maintain
expansion service in java-fn-execution while maintaining other SDK logic
related to cross-language transform expansion in pipeline construction side.
If the need is to just package expansion service withe the job server
offered by the runner, we should be able to do that without moving the
expansion service, right ? (given that java-fn-execution depends on
core-construction-java)
cc: @ihji @robertwb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 206157)
Time Spent: 1h 10m (was: 1h)
> Move Java ExpansionService into Flink JobServer
> -----------------------------------------------
>
> Key: BEAM-6731
> URL: https://issues.apache.org/jira/browse/BEAM-6731
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink, sdk-java-core
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Fix For: 2.12.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> With BEAM-6730 user can use existing Java transforms from other SDKs. This
> creates additional operational complexity because users have to bring up an
> ExpansionService separately of the JobServer for Flink.
> The Java implementation of the ExpansionService can be conveniently
> integrated into the Flink JobServer such that users only have to bring up a
> single endpoint.
> CC [~robertwb] [~chamikara] [~thw] [~angoenka]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
