[ 
https://issues.apache.org/jira/browse/BEAM-6731?focusedWorklogId=206583&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-206583
 ]

ASF GitHub Bot logged work on BEAM-6731:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Mar/19 18:45
            Start Date: 01/Mar/19 18:45
    Worklog Time Spent: 10m 
      Work Description: mxm commented on pull request #7947: [BEAM-6731] Bundle 
Java ExpansionService with Flink JobServer 
URL: https://github.com/apache/beam/pull/7947#discussion_r261715295
 
 

 ##########
 File path: runners/java-fn-execution/build.gradle
 ##########
 @@ -58,3 +58,30 @@ task testDocker(type: Test) {
     includeCategories 
"org.apache.beam.runners.fnexecution.environment.testing.NeedsDocker"
   }
 }
+
+task runExpansionService (type: JavaExec) {
 
 Review comment:
   I agree with your arguments. I thought that `fn-execution` might be the 
better place because other services also live in this module. However, the 
`ExpansionService` is clearly related to the construction of the pipeline, not 
its execution. I'll prepare a PR to move it back.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 206583)
    Time Spent: 1h 20m  (was: 1h 10m)

> Move Java ExpansionService into Flink JobServer
> -----------------------------------------------
>
>                 Key: BEAM-6731
>                 URL: https://issues.apache.org/jira/browse/BEAM-6731
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-flink, sdk-java-core
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>            Priority: Major
>             Fix For: 2.12.0
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> With BEAM-6730 user can use existing Java transforms from other SDKs. This 
> creates additional operational complexity because users have to bring up an 
> ExpansionService separately of the JobServer for Flink.
> The Java implementation of the ExpansionService can be conveniently 
> integrated into the Flink JobServer such that users only have to bring up a 
> single endpoint.
> CC [~robertwb] [~chamikara] [~thw] [~angoenka]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to