[
https://issues.apache.org/jira/browse/BEAM-12524?focusedWorklogId=613762&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-613762
]
ASF GitHub Bot logged work on BEAM-12524:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jun/21 00:18
Start Date: 23/Jun/21 00:18
Worklog Time Spent: 10m
Work Description: boyuanzz commented on a change in pull request #15062:
URL: https://github.com/apache/beam/pull/15062#discussion_r656665867
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java
##########
@@ -665,6 +667,11 @@ void release(String bundleDescriptorId, BundleProcessor
bundleProcessor) {
}
}
+ /** Discard an active {@link BundleProcessor} instead of being re-used. */
+ void discard(BundleProcessor bundleProcessor) {
+ activeBundleProcessors.remove(bundleProcessor.getInstructionId());
Review comment:
Do we want to do `bundleProcessor.setInstructionId(null);` before
discarding it to avoid the same race condition as `reset`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 613762)
Time Spent: 0.5h (was: 20m)
> Discard BundleProcessor instead of re-using it on bundle processing failure
> ---------------------------------------------------------------------------
>
> Key: BEAM-12524
> URL: https://issues.apache.org/jira/browse/BEAM-12524
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-harness
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: P2
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The BundleProcessor is being released when we catch an exception.
> This is a fix to https://github.com/apache/beam/pull/13568
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
