[
https://issues.apache.org/jira/browse/BEAM-12524?focusedWorklogId=615179&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-615179
]
ASF GitHub Bot logged work on BEAM-12524:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jun/21 20:08
Start Date: 25/Jun/21 20:08
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#15062:
URL: https://github.com/apache/beam/pull/15062#discussion_r659010369
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java
##########
@@ -742,6 +749,7 @@ synchronized void setInstructionId(String instructionId) {
}
void reset() throws Exception {
+ this.instructionId = null;
Review comment:
I think this broke Java PreCommit (it looks like this was submitted
while precommits weren't running). Running `.gradlew
:sdks:java:harness:spotbugsMain` on master right now yields:
```
Inconsistent synchronization of
org.apache.beam.fn.harness.control.ProcessBundleHandler$BundleProcessor.instructionId;
locked 66% of time
Bug type IS2_INCONSISTENT_SYNC (click for details)
In class
org.apache.beam.fn.harness.control.ProcessBundleHandler$BundleProcessor
Field
org.apache.beam.fn.harness.control.ProcessBundleHandler$BundleProcessor.instructionId
Synchronized 66% of the time
Unsynchronized access at ProcessBundleHandler.java:[line 752]
Synchronized access at ProcessBundleHandler.java:[line 748]
Synchronized access at ProcessBundleHandler.java:[line 744]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 615179)
Time Spent: 1h (was: 50m)
> Discard BundleProcessor instead of re-using it on bundle processing failure
> ---------------------------------------------------------------------------
>
> Key: BEAM-12524
> URL: https://issues.apache.org/jira/browse/BEAM-12524
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-harness
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: P2
> Fix For: 2.32.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The BundleProcessor is being released when we catch an exception.
> This is a fix to https://github.com/apache/beam/pull/13568
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
