[
https://issues.apache.org/jira/browse/BEAM-12513?focusedWorklogId=615220&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-615220
]
ASF GitHub Bot logged work on BEAM-12513:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jun/21 21:23
Start Date: 25/Jun/21 21:23
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #15057:
URL: https://github.com/apache/beam/pull/15057#discussion_r659043365
##########
File path: website/www/site/content/en/documentation/programming-guide.md
##########
@@ -522,6 +572,12 @@ together transforms to create a pipeline that successively
modifies input data:
| [Third Transform])
{{< /highlight >}}
+{{< highlight go >}}
+[Second PCollection] := beam.ParDo(s, [First Transform], [Initial Input
PCollection])
+[Third PCollection] := beam.ParDo(s, [Second Transform], [Second PCollection])
Review comment:
This one is reasonable since it's abstract code anyway. However, I'd
rather not force a generation of Go SDK users to repeatedly use `scope` for a
pervasive variable. Eventually too much such repetition is not useful and draws
focus from the distinct parts of the call.
I agree that towards the pipeline phase, we should explain the scope
variable better, what it's for (referring to the section on composites), and
that conventionally, it's abbreviated to 's' which is like how
`context.Context` is abbreviated to `ctx`, and `io.Reader` and `io.Writer`
become `r` and `w` respectively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 615220)
Time Spent: 4h 40m (was: 4.5h)
> Complete Go SDK inclusion to Beam Programming Guide
> ---------------------------------------------------
>
> Key: BEAM-12513
> URL: https://issues.apache.org/jira/browse/BEAM-12513
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P2
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> BPG Go Audit snapshot:
> [https://docs.google.com/spreadsheets/d/1DrBFjxPBmMMmPfeFr6jr_JndxGOes8qDqKZ2Uxwvvds/edit?resourcekey=0-tVFwcLrQ2v2jpZkHk6QOpQ#gid=2072310090]
> Goal is to include Go SDK code for all missing snippets, and where code can't
> yet exist, file and link a Jira instead.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
