[
https://issues.apache.org/jira/browse/BEAM-12513?focusedWorklogId=617903&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-617903
]
ASF GitHub Bot logged work on BEAM-12513:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/21 23:48
Start Date: 01/Jul/21 23:48
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #15057:
URL: https://github.com/apache/beam/pull/15057#discussion_r662652348
##########
File path: sdks/go/examples/snippets/04transforms.go
##########
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package snippets
+
+import (
+ "fmt"
+ "math"
+ "reflect"
+ "sort"
+ "strings"
+
+ "github.com/apache/beam/sdks/go/pkg/beam"
+ "github.com/apache/beam/sdks/go/pkg/beam/transforms/stats"
+)
+
+// [START model_pardo_pardo]
+
+// ComputeWordLengthFn is the DoFn to perform on each element in the input
PCollection.
+type ComputeWordLengthFn struct{}
+
+// ProcessElement is the method to execute for each element.
+func (fn *ComputeWordLengthFn) ProcessElement(word string, emit func(int)) {
Review comment:
I'm largely basing it on the Java approach which has the output context
object, rather than the python one.
Generally users will need to know the arbitrary emitters, for more complex
DoFns. The simple return case is a convenience but 1:1 is incredibly limiting.
If users don't find it, they won't hurt themselves by not knowing it.
The section is outputting multiple PCollections, not multiple elements
within a PCollection.
Similarly, that's why I didn't introduce it using a functional DoFn. It
leads to users assuming closures can work for configuration, which can't work
in Go at the moment. Structural DoFns are not the most convenient, but they are
the most versatile. They prevent errors like closure functions, which are far
harder to debug when they sometimes work and fail otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 617903)
Time Spent: 5.5h (was: 5h 20m)
> Complete Go SDK inclusion to Beam Programming Guide
> ---------------------------------------------------
>
> Key: BEAM-12513
> URL: https://issues.apache.org/jira/browse/BEAM-12513
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P2
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> BPG Go Audit snapshot:
> [https://docs.google.com/spreadsheets/d/1DrBFjxPBmMMmPfeFr6jr_JndxGOes8qDqKZ2Uxwvvds/edit?resourcekey=0-tVFwcLrQ2v2jpZkHk6QOpQ#gid=2072310090]
> Goal is to include Go SDK code for all missing snippets, and where code can't
> yet exist, file and link a Jira instead.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
