[
https://issues.apache.org/jira/browse/BEAM-10887?focusedWorklogId=616670&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-616670
]
ASF GitHub Bot logged work on BEAM-10887:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jun/21 19:02
Start Date: 29/Jun/21 19:02
Worklog Time Spent: 10m
Work Description: reuvenlax commented on a change in pull request #15056:
URL: https://github.com/apache/beam/pull/15056#discussion_r660888061
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/state/Timer.java
##########
@@ -81,6 +81,9 @@
*/
Review comment:
But that is incorrect behavior (as has been agreed on the dev list many
times). set/clear calls should take effect immediately. The fact that this is
sometimes not true has caused user bugs before because calls to modify state
take effect immediately, leading to users seeing inconsistencies between state
& timers.
I have a followon PR to fix this bug, so set/clear calls will be visible
immediately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 616670)
Time Spent: 3.5h (was: 3h 20m)
> FnApiTimer should expose clear() API
> ------------------------------------
>
> Key: BEAM-10887
> URL: https://issues.apache.org/jira/browse/BEAM-10887
> Project: Beam
> Issue Type: New Feature
> Components: beam-model, sdk-java-core
> Reporter: Boyuan Zhang
> Priority: P3
> Labels: Clarified
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Similar to python
> OutputTimer.clear():https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/worker/bundle_processor.py#L661,
> Java FnApiTimer should also expose clear() API.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
