[
https://issues.apache.org/jira/browse/BEAM-10887?focusedWorklogId=618280&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618280
]
ASF GitHub Bot logged work on BEAM-10887:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jul/21 22:21
Start Date: 02/Jul/21 22:21
Worklog Time Spent: 10m
Work Description: reuvenlax commented on a change in pull request #15056:
URL: https://github.com/apache/beam/pull/15056#discussion_r663268811
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##########
@@ -4851,6 +4851,342 @@ public void onTimer2(
return PDone.in(input.getPipeline());
}
}
+
Review comment:
Ok, but I'll add this test to my followon PR that actually fixes timers
when there are in-bundle modifications. The correct test will fail currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 618280)
Time Spent: 4h 20m (was: 4h 10m)
> FnApiTimer should expose clear() API
> ------------------------------------
>
> Key: BEAM-10887
> URL: https://issues.apache.org/jira/browse/BEAM-10887
> Project: Beam
> Issue Type: New Feature
> Components: beam-model, sdk-java-core
> Reporter: Boyuan Zhang
> Priority: P3
> Labels: Clarified
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Similar to python
> OutputTimer.clear():https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/worker/bundle_processor.py#L661,
> Java FnApiTimer should also expose clear() API.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
