[
https://issues.apache.org/jira/browse/BEAM-12513?focusedWorklogId=617920&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-617920
]
ASF GitHub Bot logged work on BEAM-12513:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jul/21 00:13
Start Date: 02/Jul/21 00:13
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #15057:
URL: https://github.com/apache/beam/pull/15057#discussion_r662659433
##########
File path: website/www/site/content/en/documentation/programming-guide.md
##########
@@ -675,10 +746,31 @@ the types of the input and output elements. If your
`DoFn` processes incoming
look like this:
{{< /paragraph >}}
+{{< paragraph class="language-go" >}}
+A `DoFn` processes one element at a time from the input `PCollection`. When you
Review comment:
I'm going to push back on this at present.
The lack of func nature is apparent in the example, immediately adjacent to
the text, and shouldn't be over explained right here. At least, not at this
point in the document. There's an entire section on syntactic sugars and
convenience abbreviations for DoFns, which introduces that funcs can be DoFns
too. I've introduced functional DoFns there since they are largely
conveniences, vs the Structural DoFns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 617920)
Time Spent: 7h (was: 6h 50m)
> Complete Go SDK inclusion to Beam Programming Guide
> ---------------------------------------------------
>
> Key: BEAM-12513
> URL: https://issues.apache.org/jira/browse/BEAM-12513
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P2
> Time Spent: 7h
> Remaining Estimate: 0h
>
> BPG Go Audit snapshot:
> [https://docs.google.com/spreadsheets/d/1DrBFjxPBmMMmPfeFr6jr_JndxGOes8qDqKZ2Uxwvvds/edit?resourcekey=0-tVFwcLrQ2v2jpZkHk6QOpQ#gid=2072310090]
> Goal is to include Go SDK code for all missing snippets, and where code can't
> yet exist, file and link a Jira instead.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
