[
https://issues.apache.org/jira/browse/BEAM-6767?focusedWorklogId=207412&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207412
]
ASF GitHub Bot logged work on BEAM-6767:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Mar/19 20:20
Start Date: 04/Mar/19 20:20
Worklog Time Spent: 10m
Work Description: lhaiesp commented on pull request #7983: [BEAM-6767]
SamzaRunner: Add more parameters to SamzaPipelineOptions
URL: https://github.com/apache/beam/pull/7983#discussion_r262226818
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ConfigBuilder.java
##########
@@ -90,25 +99,16 @@ private static boolean isEmptyUserConfig(Map<String,
String> config) {
.allMatch(key ->
key.startsWith(SamzaRunnerOverrideConfigs.BEAM_RUNNER_CONFIG_PREFIX));
}
- private static Map<String, String> createUserConfig(SamzaPipelineOptions
options)
- throws Exception {
+ private static Map<String, String> createUserConfig(SamzaPipelineOptions
options) {
final String configFilePath = options.getConfigFilePath();
final Map<String, String> config = new HashMap<>();
// If user provides a config file, use it as base configs.
if (StringUtils.isNoneEmpty(configFilePath)) {
final File configFile = new File(configFilePath);
+ checkArgument(configFile.exists(), "Config file %s does not exist",
configFilePath);
+ final PropertiesConfigFactory configFactory = new
PropertiesConfigFactory();
Review comment:
why forcing to use PropertiesConfigFactory here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 207412)
Time Spent: 40m (was: 0.5h)
> SamzaRunner: Add more parameters to SamzaPipelineOptions
> --------------------------------------------------------
>
> Key: BEAM-6767
> URL: https://issues.apache.org/jira/browse/BEAM-6767
> Project: Beam
> Issue Type: Improvement
> Components: runner-samza
> Reporter: Xinyu Liu
> Assignee: Xinyu Liu
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Add the following parameter support:
> 1. Allow enable/disable beam metrics in SamzaPipelineOptions
> 2. Enable durable state with Samza pipeline options
> 3. Enable host-affinity for durable state
> Also fixed a bug to update watermark hold state only when it's changed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
