[
https://issues.apache.org/jira/browse/BEAM-6767?focusedWorklogId=207408&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207408
]
ASF GitHub Bot logged work on BEAM-6767:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Mar/19 20:17
Start Date: 04/Mar/19 20:17
Worklog Time Spent: 10m
Work Description: lhaiesp commented on pull request #7983: [BEAM-6767]
SamzaRunner: Add more parameters to SamzaPipelineOptions
URL: https://github.com/apache/beam/pull/7983#discussion_r262225857
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ConfigBuilder.java
##########
@@ -66,16 +65,26 @@ public void putAll(Map<String, String> properties) {
public Config build() {
try {
- config.putAll(systemStoreConfig());
+ config.putAll(systemStoreConfig(options));
// apply user configs
config.putAll(createUserConfig(options));
config.put(JobConfig.JOB_NAME(), options.getJobName());
+ config.put(JobConfig.JOB_ID(), options.getJobInstance());
+
config.put(
"beamPipelineOptions",
Base64Serializer.serializeUnchecked(new
SerializablePipelineOptions(options)));
+ // TODO: remove after SAMZA-1531 is resolved
Review comment:
what's the reason to move it from localRunConfig to here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 207408)
Time Spent: 0.5h (was: 20m)
> SamzaRunner: Add more parameters to SamzaPipelineOptions
> --------------------------------------------------------
>
> Key: BEAM-6767
> URL: https://issues.apache.org/jira/browse/BEAM-6767
> Project: Beam
> Issue Type: Improvement
> Components: runner-samza
> Reporter: Xinyu Liu
> Assignee: Xinyu Liu
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Add the following parameter support:
> 1. Allow enable/disable beam metrics in SamzaPipelineOptions
> 2. Enable durable state with Samza pipeline options
> 3. Enable host-affinity for durable state
> Also fixed a bug to update watermark hold state only when it's changed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
