[ 
https://issues.apache.org/jira/browse/BEAM-12593?focusedWorklogId=623800&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-623800
 ]

ASF GitHub Bot logged work on BEAM-12593:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Jul/21 18:49
            Start Date: 16/Jul/21 18:49
    Worklog Time Spent: 10m 
      Work Description: rohdesamuel commented on a change in pull request 
#15165:
URL: https://github.com/apache/beam/pull/15165#discussion_r671461625



##########
File path: sdks/python/apache_beam/dataframe/pandas_doctests_test.py
##########
@@ -491,12 +503,13 @@ def test_series_tests(self):
                 # Inspection after modification.
                 's'
             ],
+            'pandas.core.series.Series.resample': ['df'],
         })
     self.assertEqual(result.failed, 0)
 
   def test_string_tests(self):
-    PD_VERSION = tuple(int(v) for v in pd.__version__.split('.'))
-    if PD_VERSION < (1, 2, 0):
+    PD_VERSION = tuple(int(v) for v in pd.__version__.split('.')[:2])

Review comment:
       Rewritten to get the PD_VERSION from frames.py. Probably not worth it to 
keep the patch veresion.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 623800)
    Time Spent: 1h 10m  (was: 1h)

> DataFrame API: Support pandas 1.3.x
> -----------------------------------
>
>                 Key: BEAM-12593
>                 URL: https://issues.apache.org/jira/browse/BEAM-12593
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-dataframe
>            Reporter: Brian Hulette
>            Priority: P2
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Started a WIP PR here: https://github.com/apache/beam/pull/15008 that used 
> rc1. Now the official 1.3.0 is out.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to