[
https://issues.apache.org/jira/browse/BEAM-12593?focusedWorklogId=623804&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-623804
]
ASF GitHub Bot logged work on BEAM-12593:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/21 18:56
Start Date: 16/Jul/21 18:56
Worklog Time Spent: 10m
Work Description: rohdesamuel commented on a change in pull request
#15165:
URL: https://github.com/apache/beam/pull/15165#discussion_r671465231
##########
File path: sdks/python/apache_beam/dataframe/pandas_doctests_test.py
##########
@@ -386,6 +394,7 @@ def test_series_tests(self):
],
'pandas.core.series.Series.fillna': [
"df.fillna(method='ffill')",
+ 'df.fillna(method="ffill")',
Review comment:
Pandas changed from single to double quotes in 1.3.0, so we need to add
this extra line in.
##########
File path: sdks/python/apache_beam/dataframe/pandas_doctests_test.py
##########
@@ -69,6 +69,7 @@ def test_ndframe_tests(self):
],
'pandas.core.generic.NDFrame.fillna': [
"df.fillna(method='ffill')",
+ 'df.fillna(method="ffill")',
Review comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 623804)
Time Spent: 1h 20m (was: 1h 10m)
> DataFrame API: Support pandas 1.3.x
> -----------------------------------
>
> Key: BEAM-12593
> URL: https://issues.apache.org/jira/browse/BEAM-12593
> Project: Beam
> Issue Type: Improvement
> Components: dsl-dataframe
> Reporter: Brian Hulette
> Priority: P2
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Started a WIP PR here: https://github.com/apache/beam/pull/15008 that used
> rc1. Now the official 1.3.0 is out.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
