[
https://issues.apache.org/jira/browse/BEAM-562?focusedWorklogId=208083&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-208083
]
ASF GitHub Bot logged work on BEAM-562:
---------------------------------------
Author: ASF GitHub Bot
Created on: 05/Mar/19 21:28
Start Date: 05/Mar/19 21:28
Worklog Time Spent: 10m
Work Description: charlesccychen commented on pull request #7994:
[BEAM-562] Add DoFn.setup and DoFn.teardown to Python SDK
URL: https://github.com/apache/beam/pull/7994#discussion_r262696829
##########
File path: sdks/python/apache_beam/runners/worker/operations.py
##########
@@ -216,6 +216,9 @@ def finish(self):
"""Finish operation."""
pass
+ def teardown(self):
Review comment:
Can we avoid adding setup() and teardown() to the general Operation class?
I don't expect operations other than DoOperation to have these lifecycle
functions. Instead, we should call DoFnRunner.setup() in DoOperation.start()
and DoFnRunner.teardown() in DoOperation.finish(). This way, we don't need to
pipe changes up into bundle_processor.py and fn_api_runner.py.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 208083)
Time Spent: 40m (was: 0.5h)
> DoFn Reuse: Add new methods to DoFn
> -----------------------------------
>
> Key: BEAM-562
> URL: https://issues.apache.org/jira/browse/BEAM-562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Ahmet Altay
> Priority: Major
> Labels: sdk-consistency, triaged
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Java SDK added setup and teardown methods to the DoFns. This makes DoFns
> reusable and provide performance improvements. Python SDK should add support
> for these new DoFn methods:
> Proposal doc:
> https://docs.google.com/document/d/1LLQqggSePURt3XavKBGV7SZJYQ4NW8yCu63lBchzMRk/edit?ts=5771458f#
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
