[
https://issues.apache.org/jira/browse/BEAM-562?focusedWorklogId=208121&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-208121
]
ASF GitHub Bot logged work on BEAM-562:
---------------------------------------
Author: ASF GitHub Bot
Created on: 05/Mar/19 22:16
Start Date: 05/Mar/19 22:16
Worklog Time Spent: 10m
Work Description: yifanmai commented on pull request #7994: [BEAM-562]
Add DoFn.setup and DoFn.teardown to Python SDK
URL: https://github.com/apache/beam/pull/7994#discussion_r262714400
##########
File path: sdks/python/apache_beam/runners/worker/operations.py
##########
@@ -216,6 +216,9 @@ def finish(self):
"""Finish operation."""
pass
+ def teardown(self):
Review comment:
Ah, I did not realize that `Operation.start` and `Operation.finish` was
called once per instance rather than once per bundle.
The main reason for moving `setup` and `teardown` to `Operation` would be to
support adding `setup` and `teardown` to `CombineFn` for
[BEAM-3736](https://issues.apache.org/jira/browse/BEAM-3736). That said, the
change can be made directly in `PGBKCVOperation` and `FlattenOperation` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 208121)
Time Spent: 50m (was: 40m)
> DoFn Reuse: Add new methods to DoFn
> -----------------------------------
>
> Key: BEAM-562
> URL: https://issues.apache.org/jira/browse/BEAM-562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Ahmet Altay
> Priority: Major
> Labels: sdk-consistency, triaged
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Java SDK added setup and teardown methods to the DoFns. This makes DoFns
> reusable and provide performance improvements. Python SDK should add support
> for these new DoFn methods:
> Proposal doc:
> https://docs.google.com/document/d/1LLQqggSePURt3XavKBGV7SZJYQ4NW8yCu63lBchzMRk/edit?ts=5771458f#
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
