[
https://issues.apache.org/jira/browse/BEAM-6770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785769#comment-16785769
]
Michael Luckey commented on BEAM-6770:
--------------------------------------
[~jeff.klu...@gmail.com] To put it into test runtime, couldn't we simply use
testRuntime configuration? IIUC the dependency is not required to compile,
right?
To get it into optional scope, that is not natively supported by gradle. We
probably need to either run our own or use e.g. nebula.optional-base plugin [1]
Did not look into the shading and problems for downstream projects consuming
java-sdk-core, though.
[1] https://github.com/nebula-plugins/gradle-extra-configurations-plugin
> Correct zstd-jni dependency scope to optional
> ---------------------------------------------
>
> Key: BEAM-6770
> URL: https://issues.apache.org/jira/browse/BEAM-6770
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Romain Manni-Bucau
> Priority: Major
>
> Beam 2.11.0 introduced a new transitive dep aka zstd-jni. AFAIK it is not
> needed in most cases so shouldn't be here by default. Also saw it was
> configured as shadow in the sdk core java module so not sure it is a gradle
> build bug or intended to be like that but I think sdk-core-java should be
> cleaned up cause it is now very fast and does not match a lot of usage.
> Finally this lib being native it is not that sane to bring it by default, in
> particular with the dockerization happening right now and the goal to have a
> light container stack (which often implies to not use standard linux as FROM).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
